summaryrefslogtreecommitdiff
path: root/linux-core/mga_drv.c
blob: 14a0be45e04378925cbfadb01e931ef898b76835 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
/* mga_drv.c -- Matrox G200/G400 driver -*- linux-c -*-
 * Created: Mon Dec 13 01:56:22 1999 by jhartmann@precisioninsight.com
 *
 * Copyright 1999 Precision Insight, Inc., Cedar Park, Texas.
 * Copyright 2000 VA Linux Systems, Inc., Sunnyvale, California.
 * All Rights Reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 * OTHER DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *    Rickard E. (Rik) Faith <faith@valinux.com>
 *    Gareth Hughes <gareth@valinux.com>
 */

#include "drmP.h"
#include "drm.h"
#include "mga_drm.h"
#include "mga_drv.h"

#include "drm_pciids.h"

static int mga_driver_device_is_agp(struct drm_device * dev);

static struct pci_device_id pciidlist[] = {
	mga_PCI_IDS
};

static int probe(struct pci_dev *pdev, const struct pci_device_id *ent);
static struct drm_driver driver = {
	.driver_features =
	    DRIVER_USE_AGP | DRIVER_USE_MTRR | DRIVER_PCI_DMA |
	    DRIVER_HAVE_DMA | DRIVER_HAVE_IRQ | DRIVER_IRQ_SHARED,
	.dev_priv_size = sizeof (drm_mga_buf_priv_t),
	.load = mga_driver_load,
	.unload = mga_driver_unload,
	.lastclose = mga_driver_lastclose,
	.dma_quiescent = mga_driver_dma_quiescent,
	.device_is_agp = mga_driver_device_is_agp,
	.get_vblank_counter = mga_get_vblank_counter,
	.enable_vblank = mga_enable_vblank,
	.disable_vblank = mga_disable_vblank,
	.irq_preinstall = mga_driver_irq_preinstall,
	.irq_postinstall = mga_driver_irq_postinstall,
	.irq_uninstall = mga_driver_irq_uninstall,
	.irq_handler = mga_driver_irq_handler,
	.reclaim_buffers = drm_core_reclaim_buffers,
	.get_map_ofs = drm_core_get_map_ofs,
	.get_reg_ofs = drm_core_get_reg_ofs,
	.ioctls = mga_ioctls,
	.dma_ioctl = mga_dma_buffers,
	.fops = {
		.owner = THIS_MODULE,
		.open = drm_open,
		.release = drm_release,
		.ioctl = drm_ioctl,
		.mmap = drm_mmap,
		.poll = drm_poll,
		.fasync = drm_fasync,
#if defined(CONFIG_COMPAT) && LINUX_VERSION_CODE > KERNEL_VERSION(2,6,9)
		.compat_ioctl = mga_compat_ioctl,
#endif
		},
	.pci_driver = {
		.name = DRIVER_NAME,
		.id_table = pciidlist,
		.probe = probe,
		.remove = __devexit_p(drm_cleanup_pci),
	},

	.name = DRIVER_NAME,
	.desc = DRIVER_DESC,
	.date = DRIVER_DATE,
	.major = DRIVER_MAJOR,
	.minor = DRIVER_MINOR,
	.patchlevel = DRIVER_PATCHLEVEL,
};

static int probe(struct pci_dev *pdev, const struct pci_device_id *ent)
{
	return drm_get_dev(pdev, ent, &driver);
}


static int __init mga_init(void)
{
	driver.num_ioctls = mga_max_ioctl;
	return drm_init(&driver, pciidlist);
}

static void __exit mga_exit(void)
{
	drm_exit(&driver);
}

module_init(mga_init);
module_exit(mga_exit);

MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL and additional rights");

/**
 * Determine if the device really is AGP or not.
 *
 * In addition to the usual tests performed by \c drm_device_is_agp, this
 * function detects PCI G450 cards that appear to the system exactly like
 * AGP G450 cards.
 *
 * \param dev   The device to be tested.
 *
 * \returns
 * If the device is a PCI G450, zero is returned.  Otherwise 2 is returned.
 */
static int mga_driver_device_is_agp(struct drm_device * dev)
{
	const struct pci_dev * const pdev = dev->pdev;


	/* There are PCI versions of the G450.  These cards have the
	 * same PCI ID as the AGP G450, but have an additional PCI-to-PCI
	 * bridge chip.  We detect these cards, which are not currently
	 * supported by this driver, by looking at the device ID of the
	 * bus the "card" is on.  If vendor is 0x3388 (Hint Corp) and the
	 * device is 0x0021 (HB6 Universal PCI-PCI bridge), we reject the
	 * device.
	 */

	if ((pdev->device == 0x0525) && pdev->bus->self
	    && (pdev->bus->self->vendor == 0x3388)
	    && (pdev->bus->self->device == 0x0021)) {
		return 0;
	}

	return 2;
}
56 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361
/*
 * Copyright 2007-8 Advanced Micro Devices, Inc.
 * Copyright 2008 Red Hat Inc.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 * OTHER DEALINGS IN THE SOFTWARE.
 *
 * Authors: Dave Airlie
 *          Alex Deucher
 */
#include "drmP.h"
#include "drm_crtc_helper.h"
#include "radeon_drm.h"
#include "radeon_drv.h"


static void radeon_legacy_rmx_mode_set(struct drm_encoder *encoder,
				       struct drm_display_mode *mode,
				       struct drm_display_mode *adjusted_mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
	int    xres = mode->hdisplay;
	int    yres = mode->vdisplay;
	bool   hscale = true, vscale = true;
	int    hsync_wid;
	int    vsync_wid;
	int    hsync_start;
	uint32_t scale, inc;
	uint32_t fp_horz_stretch, fp_vert_stretch, crtc_more_cntl, fp_horz_vert_active;
	uint32_t fp_h_sync_strt_wid, fp_v_sync_strt_wid, fp_crtc_h_total_disp, fp_crtc_v_total_disp;

	DRM_DEBUG("\n");

	fp_vert_stretch = RADEON_READ(RADEON_FP_VERT_STRETCH) &
		(RADEON_VERT_STRETCH_RESERVED |
		 RADEON_VERT_AUTO_RATIO_INC);
	fp_horz_stretch = RADEON_READ(RADEON_FP_HORZ_STRETCH) &
		(RADEON_HORZ_FP_LOOP_STRETCH |
		 RADEON_HORZ_AUTO_RATIO_INC);

	crtc_more_cntl = 0;
	if ((dev_priv->chip_family == CHIP_RS100) ||
	    (dev_priv->chip_family == CHIP_RS200)) {
		/* This is to workaround the asic bug for RMX, some versions
		   of BIOS dosen't have this register initialized correctly. */
		crtc_more_cntl |= RADEON_CRTC_H_CUTOFF_ACTIVE_EN;
	}


	fp_crtc_h_total_disp = ((((mode->crtc_htotal / 8) - 1) & 0x3ff)
				| ((((mode->crtc_hdisplay / 8) - 1) & 0x1ff) << 16));

	hsync_wid = (mode->crtc_hsync_end - mode->crtc_hsync_start) / 8;
	if (!hsync_wid)
		hsync_wid = 1;
	hsync_start = mode->crtc_hsync_start - 8;

	fp_h_sync_strt_wid = ((hsync_start & 0x1fff)
			      | ((hsync_wid & 0x3f) << 16)
			      | ((mode->flags & DRM_MODE_FLAG_NHSYNC)
				 ? RADEON_CRTC_H_SYNC_POL
				 : 0));

	fp_crtc_v_total_disp = (((mode->crtc_vtotal - 1) & 0xffff)
				| ((mode->crtc_vdisplay - 1) << 16));

	vsync_wid = mode->crtc_vsync_end - mode->crtc_vsync_start;
	if (!vsync_wid)
		vsync_wid = 1;

	fp_v_sync_strt_wid = (((mode->crtc_vsync_start - 1) & 0xfff)
			      | ((vsync_wid & 0x1f) << 16)
			      | ((mode->flags & DRM_MODE_FLAG_NVSYNC)
				 ? RADEON_CRTC_V_SYNC_POL
				 : 0));

	fp_horz_vert_active = 0;

	if (radeon_encoder->panel_xres == 0 ||
	    radeon_encoder->panel_yres == 0) {
		hscale = false;
		vscale = false;
	} else {
		if (xres > radeon_encoder->panel_xres)
			xres = radeon_encoder->panel_xres;
		if (yres > radeon_encoder->panel_yres)
			yres = radeon_encoder->panel_yres;

		if (xres == radeon_encoder->panel_xres)
			hscale = false;
		if (yres == radeon_encoder->panel_yres)
			vscale = false;
	}

	if (radeon_encoder->flags & RADEON_USE_RMX) {
		if (radeon_encoder->rmx_type != RMX_CENTER) {
			if (!hscale)
				fp_horz_stretch |= ((xres/8-1) << 16);
			else {
				inc = (fp_horz_stretch & RADEON_HORZ_AUTO_RATIO_INC) ? 1 : 0;
				scale = ((xres + inc) * RADEON_HORZ_STRETCH_RATIO_MAX)
					/ radeon_encoder->panel_xres + 1;
				fp_horz_stretch |= (((scale) & RADEON_HORZ_STRETCH_RATIO_MASK) |
						    RADEON_HORZ_STRETCH_BLEND |
						    RADEON_HORZ_STRETCH_ENABLE |
						    ((radeon_encoder->panel_xres/8-1) << 16));
			}

			if (!vscale)
				fp_vert_stretch |= ((yres-1) << 12);
			else {
				inc = (fp_vert_stretch & RADEON_VERT_AUTO_RATIO_INC) ? 1 : 0;
				scale = ((yres + inc) * RADEON_VERT_STRETCH_RATIO_MAX)
					/ radeon_encoder->panel_yres + 1;
				fp_vert_stretch |= (((scale) & RADEON_VERT_STRETCH_RATIO_MASK) |
						    RADEON_VERT_STRETCH_ENABLE |
						    RADEON_VERT_STRETCH_BLEND |
						    ((radeon_encoder->panel_yres-1) << 12));
			}
		} else if (radeon_encoder->rmx_type == RMX_CENTER) {
			int    blank_width;

			fp_horz_stretch |= ((xres/8-1) << 16);
			fp_vert_stretch |= ((yres-1) << 12);

			crtc_more_cntl |= (RADEON_CRTC_AUTO_HORZ_CENTER_EN |
					   RADEON_CRTC_AUTO_VERT_CENTER_EN);

			blank_width = (mode->crtc_hblank_end - mode->crtc_hblank_start) / 8;
			if (blank_width > 110)
				blank_width = 110;

			fp_crtc_h_total_disp = (((blank_width) & 0x3ff)
						| ((((mode->crtc_hdisplay / 8) - 1) & 0x1ff) << 16));

			hsync_wid = (mode->crtc_hsync_end - mode->crtc_hsync_start) / 8;
			if (!hsync_wid)
				hsync_wid = 1;

			fp_h_sync_strt_wid = ((((mode->crtc_hsync_start - mode->crtc_hblank_start) / 8) & 0x1fff)
					      | ((hsync_wid & 0x3f) << 16)
					      | ((mode->flags & DRM_MODE_FLAG_NHSYNC)
						 ? RADEON_CRTC_H_SYNC_POL
						 : 0));

			fp_crtc_v_total_disp = (((mode->crtc_vblank_end - mode->crtc_vblank_start) & 0xffff)
						| ((mode->crtc_vdisplay - 1) << 16));

			vsync_wid = mode->crtc_vsync_end - mode->crtc_vsync_start;
			if (!vsync_wid)
				vsync_wid = 1;

			fp_v_sync_strt_wid = ((((mode->crtc_vsync_start - mode->crtc_vblank_start) & 0xfff)
					       | ((vsync_wid & 0x1f) << 16)
					       | ((mode->flags & DRM_MODE_FLAG_NVSYNC)
						  ? RADEON_CRTC_V_SYNC_POL
						  : 0)));

			fp_horz_vert_active = (((radeon_encoder->panel_yres) & 0xfff) |
					       (((radeon_encoder->panel_xres / 8) & 0x1ff) << 16));
		}
	} else {
		fp_horz_stretch |= ((xres/8-1) << 16);
		fp_vert_stretch |= ((yres-1) << 12);
	}

	RADEON_WRITE(RADEON_FP_HORZ_STRETCH,      fp_horz_stretch);
	RADEON_WRITE(RADEON_FP_VERT_STRETCH,      fp_vert_stretch);
	RADEON_WRITE(RADEON_CRTC_MORE_CNTL,       crtc_more_cntl);
	RADEON_WRITE(RADEON_FP_HORZ_VERT_ACTIVE,  fp_horz_vert_active);
	RADEON_WRITE(RADEON_FP_H_SYNC_STRT_WID,   fp_h_sync_strt_wid);
	RADEON_WRITE(RADEON_FP_V_SYNC_STRT_WID,   fp_v_sync_strt_wid);
	RADEON_WRITE(RADEON_FP_CRTC_H_TOTAL_DISP, fp_crtc_h_total_disp);
	RADEON_WRITE(RADEON_FP_CRTC_V_TOTAL_DISP, fp_crtc_v_total_disp);

}

static void radeon_legacy_lvds_dpms(struct drm_encoder *encoder, int mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
	struct radeon_crtc *radeon_crtc;
	uint32_t lvds_gen_cntl, lvds_pll_cntl, pixclks_cntl, disp_pwr_man;
	uint32_t bios_5_scratch, bios_6_scratch;
	int crtc_id = 0;
	DRM_DEBUG("\n");

	if (encoder->crtc) {
		radeon_crtc = to_radeon_crtc(encoder->crtc);
		crtc_id = radeon_crtc->crtc_id;
	}

	// FIXME atom/legacy cards like r4xx
	bios_5_scratch = RADEON_READ(RADEON_BIOS_5_SCRATCH);
	bios_6_scratch = RADEON_READ(RADEON_BIOS_6_SCRATCH);

	bios_5_scratch &= ~RADEON_LCD1_CRTC_MASK;
	bios_5_scratch |= (crtc_id << RADEON_LCD1_CRTC_SHIFT);

	switch (mode) {
	case DRM_MODE_DPMS_ON:
		disp_pwr_man = RADEON_READ(RADEON_DISP_PWR_MAN);
		disp_pwr_man |= RADEON_AUTO_PWRUP_EN;
		RADEON_WRITE(RADEON_DISP_PWR_MAN, disp_pwr_man);
		lvds_pll_cntl = RADEON_READ(RADEON_LVDS_PLL_CNTL);
		lvds_pll_cntl |= RADEON_LVDS_PLL_EN;
		RADEON_WRITE(RADEON_LVDS_PLL_CNTL, lvds_pll_cntl);
		udelay(1000);

		lvds_pll_cntl = RADEON_READ(RADEON_LVDS_PLL_CNTL);
		lvds_pll_cntl &= ~RADEON_LVDS_PLL_RESET;
		RADEON_WRITE(RADEON_LVDS_PLL_CNTL, lvds_pll_cntl);

		lvds_gen_cntl = RADEON_READ(RADEON_LVDS_GEN_CNTL);
		lvds_gen_cntl |= (RADEON_LVDS_ON | RADEON_LVDS_EN | RADEON_LVDS_DIGON | RADEON_LVDS_BLON);
		lvds_gen_cntl &= ~(RADEON_LVDS_DISPLAY_DIS);
		udelay(radeon_encoder->panel_pwr_delay * 1000);
		RADEON_WRITE(RADEON_LVDS_GEN_CNTL, lvds_gen_cntl);

		/* update bios scratch regs */
		bios_5_scratch |= RADEON_LCD1_ON;
		bios_6_scratch |= RADEON_LCD_DPMS_ON;

		break;
	case DRM_MODE_DPMS_STANDBY:
	case DRM_MODE_DPMS_SUSPEND:
	case DRM_MODE_DPMS_OFF:
		pixclks_cntl = RADEON_READ_PLL(dev_priv, RADEON_PIXCLKS_CNTL);
		RADEON_WRITE_PLL_P(dev_priv, RADEON_PIXCLKS_CNTL, 0, ~RADEON_PIXCLK_LVDS_ALWAYS_ONb);
		lvds_gen_cntl = RADEON_READ(RADEON_LVDS_GEN_CNTL);
		lvds_gen_cntl |= RADEON_LVDS_DISPLAY_DIS;
		lvds_gen_cntl &= ~(RADEON_LVDS_ON | RADEON_LVDS_BLON | RADEON_LVDS_EN | RADEON_LVDS_DIGON);
		udelay(radeon_encoder->panel_pwr_delay * 1000);
		RADEON_WRITE(RADEON_LVDS_GEN_CNTL, lvds_gen_cntl);
		RADEON_WRITE_PLL(dev_priv, RADEON_PIXCLKS_CNTL, pixclks_cntl);

		bios_5_scratch &= ~RADEON_LCD1_ON;
		bios_6_scratch &= ~RADEON_LCD_DPMS_ON;
		break;
	}
	RADEON_WRITE(RADEON_BIOS_5_SCRATCH, bios_5_scratch);
	RADEON_WRITE(RADEON_BIOS_6_SCRATCH, bios_6_scratch);
}

static void radeon_legacy_lvds_prepare(struct drm_encoder *encoder)
{
	struct drm_radeon_private *dev_priv = encoder->dev->dev_private;
	// fix me: atom/legacy r4xx
	if (!dev_priv->is_atom_bios)
		radeon_combios_output_lock(encoder, true);
	radeon_legacy_lvds_dpms(encoder, DRM_MODE_DPMS_OFF);
}

static void radeon_legacy_lvds_commit(struct drm_encoder *encoder)
{
	struct drm_radeon_private *dev_priv = encoder->dev->dev_private;
	radeon_legacy_lvds_dpms(encoder, DRM_MODE_DPMS_ON);
	// fix me: atom/legacy r4xx
	if (!dev_priv->is_atom_bios)
		radeon_combios_output_lock(encoder, false);
}

static void radeon_legacy_lvds_mode_set(struct drm_encoder *encoder,
					struct drm_display_mode *mode,
					struct drm_display_mode *adjusted_mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_crtc *radeon_crtc = to_radeon_crtc(encoder->crtc);
	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
	uint32_t lvds_pll_cntl, lvds_gen_cntl, lvds_ss_gen_cntl;

	DRM_DEBUG("\n");

	if (radeon_crtc->crtc_id == 0)
		radeon_legacy_rmx_mode_set(encoder, mode, adjusted_mode);

	lvds_pll_cntl = RADEON_READ(RADEON_LVDS_PLL_CNTL);
	lvds_pll_cntl &= ~RADEON_LVDS_PLL_EN;
	if (radeon_encoder->lvds_gen_cntl)
		lvds_gen_cntl = radeon_encoder->lvds_gen_cntl;
	else
		lvds_gen_cntl = RADEON_READ(RADEON_LVDS_GEN_CNTL);
	lvds_gen_cntl |= RADEON_LVDS_DISPLAY_DIS;
	lvds_gen_cntl &= ~(RADEON_LVDS_ON |
			   RADEON_LVDS_BLON |
			   RADEON_LVDS_EN |
			   RADEON_LVDS_RST_FM);

	DRM_INFO("bios LVDS_GEN_CNTL: 0x%x\n", radeon_encoder->lvds_gen_cntl);

	if (radeon_is_r300(dev_priv))
		lvds_pll_cntl &= ~(R300_LVDS_SRC_SEL_MASK);

	if (radeon_crtc->crtc_id == 0) {
		if (radeon_is_r300(dev_priv)) {
			if (radeon_encoder->flags & RADEON_USE_RMX)
				lvds_pll_cntl |= R300_LVDS_SRC_SEL_RMX;
		} else
			lvds_gen_cntl &= ~RADEON_LVDS_SEL_CRTC2;
	} else {
		if (radeon_is_r300(dev_priv))
			lvds_pll_cntl |= R300_LVDS_SRC_SEL_CRTC2;
		else
			lvds_gen_cntl |= RADEON_LVDS_SEL_CRTC2;
	}

	RADEON_WRITE(RADEON_LVDS_GEN_CNTL, lvds_gen_cntl);
	RADEON_WRITE(RADEON_LVDS_PLL_CNTL, lvds_pll_cntl);

	lvds_ss_gen_cntl = RADEON_READ(RADEON_LVDS_SS_GEN_CNTL);
	if (radeon_encoder->panel_digon_delay &&
	    radeon_encoder->panel_blon_delay) {
		lvds_ss_gen_cntl &= ~((0xf << RADEON_LVDS_PWRSEQ_DELAY1_SHIFT) |
				      (0xf << RADEON_LVDS_PWRSEQ_DELAY2_SHIFT));
		lvds_ss_gen_cntl |= ((radeon_encoder->panel_digon_delay << RADEON_LVDS_PWRSEQ_DELAY1_SHIFT) |
				     (radeon_encoder->panel_blon_delay << RADEON_LVDS_PWRSEQ_DELAY2_SHIFT));
		RADEON_WRITE(RADEON_LVDS_SS_GEN_CNTL, lvds_ss_gen_cntl);
	}

	if (dev_priv->chip_family == CHIP_RV410)
		RADEON_WRITE(RADEON_CLOCK_CNTL_INDEX, 0);
}

static bool radeon_legacy_lvds_mode_fixup(struct drm_encoder *encoder,
					  struct drm_display_mode *mode,
					  struct drm_display_mode *adjusted_mode)
{
	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);

	radeon_encoder->flags &= ~RADEON_USE_RMX;

	if (radeon_encoder->rmx_type != RMX_OFF)
		radeon_rmx_mode_fixup(encoder, mode, adjusted_mode);

	return true;
}

static const struct drm_encoder_helper_funcs radeon_legacy_lvds_helper_funcs = {
	.dpms = radeon_legacy_lvds_dpms,
	.mode_fixup = radeon_legacy_lvds_mode_fixup,
	.prepare = radeon_legacy_lvds_prepare,
	.mode_set = radeon_legacy_lvds_mode_set,
	.commit = radeon_legacy_lvds_commit,
};


static const struct drm_encoder_funcs radeon_legacy_lvds_enc_funcs = {
	.destroy = radeon_enc_destroy,
};


struct drm_encoder *radeon_encoder_legacy_lvds_add(struct drm_device *dev, int bios_index)
{
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_encoder *radeon_encoder;
	struct drm_encoder *encoder;

	DRM_DEBUG("\n");

	radeon_encoder = kzalloc(sizeof(struct radeon_encoder), GFP_KERNEL);
	if (!radeon_encoder) {
		return NULL;
	}

	encoder = &radeon_encoder->base;

	/* Limit LVDS to crtc 0 for RMX */
	encoder->possible_crtcs = 0x1;
	encoder->possible_clones = 0;
	drm_encoder_init(dev, encoder, &radeon_legacy_lvds_enc_funcs,
			 DRM_MODE_ENCODER_LVDS);

	drm_encoder_helper_add(encoder, &radeon_legacy_lvds_helper_funcs);

	/* get the lvds info from the bios */
	if (dev_priv->is_atom_bios)
		radeon_atombios_get_lvds_info(radeon_encoder);
	else
		radeon_combios_get_lvds_info(radeon_encoder);

	/* LVDS gets default RMX full scaling */
	radeon_encoder->rmx_type = RMX_FULL;

	return encoder;
}

static bool radeon_legacy_primary_dac_mode_fixup(struct drm_encoder *encoder,
						 struct drm_display_mode *mode,
						 struct drm_display_mode *adjusted_mode)
{
	return true;
}

static void radeon_legacy_primary_dac_dpms(struct drm_encoder *encoder, int mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_crtc *radeon_crtc;
	uint32_t crtc_ext_cntl = RADEON_READ(RADEON_CRTC_EXT_CNTL);
	uint32_t dac_cntl = RADEON_READ(RADEON_DAC_CNTL);
	uint32_t dac_macro_cntl = RADEON_READ(RADEON_DAC_MACRO_CNTL);
	uint32_t bios_5_scratch, bios_6_scratch;
	int crtc_id = 0;

	DRM_DEBUG("\n");

	if (encoder->crtc) {
		radeon_crtc = to_radeon_crtc(encoder->crtc);
		crtc_id = radeon_crtc->crtc_id;
	}

	// FIXME atom/legacy cards like r4xx
	bios_5_scratch = RADEON_READ(RADEON_BIOS_5_SCRATCH);
	bios_6_scratch = RADEON_READ(RADEON_BIOS_6_SCRATCH);

	bios_5_scratch &= ~RADEON_CRT1_CRTC_MASK;
	bios_5_scratch |= (crtc_id << RADEON_CRT1_CRTC_SHIFT);

	DRM_DEBUG("\n");

	switch(mode) {
	case DRM_MODE_DPMS_ON:
		crtc_ext_cntl |= RADEON_CRTC_CRT_ON;
		dac_cntl &= ~RADEON_DAC_PDWN;
		dac_macro_cntl &= ~(RADEON_DAC_PDWN_R |
				    RADEON_DAC_PDWN_G |
				    RADEON_DAC_PDWN_B);
		bios_5_scratch |= RADEON_CRT1_ON;
		bios_6_scratch |= RADEON_CRT_DPMS_ON;
		break;
	case DRM_MODE_DPMS_STANDBY:
	case DRM_MODE_DPMS_SUSPEND:
	case DRM_MODE_DPMS_OFF:
		crtc_ext_cntl &= ~RADEON_CRTC_CRT_ON;
		dac_cntl |= RADEON_DAC_PDWN;
		dac_macro_cntl |= (RADEON_DAC_PDWN_R |
				   RADEON_DAC_PDWN_G |
				   RADEON_DAC_PDWN_B);
		bios_5_scratch &= ~RADEON_CRT1_ON;
		bios_6_scratch &= ~RADEON_CRT_DPMS_ON;
		break;
	}

	RADEON_WRITE(RADEON_CRTC_EXT_CNTL, crtc_ext_cntl);
	RADEON_WRITE(RADEON_DAC_CNTL, dac_cntl);
	RADEON_WRITE(RADEON_DAC_MACRO_CNTL, dac_macro_cntl);

	RADEON_WRITE(RADEON_BIOS_5_SCRATCH, bios_5_scratch);
	RADEON_WRITE(RADEON_BIOS_6_SCRATCH, bios_6_scratch);
}

static void radeon_legacy_primary_dac_prepare(struct drm_encoder *encoder)
{
	struct drm_radeon_private *dev_priv = encoder->dev->dev_private;
	// fix me: atom/legacy r4xx
	if (!dev_priv->is_atom_bios)
		radeon_combios_output_lock(encoder, true);
	radeon_legacy_primary_dac_dpms(encoder, DRM_MODE_DPMS_OFF);
}

static void radeon_legacy_primary_dac_commit(struct drm_encoder *encoder)
{
	struct drm_radeon_private *dev_priv = encoder->dev->dev_private;
	radeon_legacy_primary_dac_dpms(encoder, DRM_MODE_DPMS_ON);
	// fix me: atom/legacy r4xx
	if (!dev_priv->is_atom_bios)
		radeon_combios_output_lock(encoder, false);
}

static void radeon_legacy_primary_dac_mode_set(struct drm_encoder *encoder,
					       struct drm_display_mode *mode,
					       struct drm_display_mode *adjusted_mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_crtc *radeon_crtc = to_radeon_crtc(encoder->crtc);
	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
	uint32_t disp_output_cntl, dac_cntl, dac2_cntl, dac_macro_cntl;

	DRM_DEBUG("\n");

	if (radeon_crtc->crtc_id == 0)
		radeon_legacy_rmx_mode_set(encoder, mode, adjusted_mode);

	if (radeon_crtc->crtc_id == 0) {
		if (dev_priv->chip_family == CHIP_R200 || radeon_is_r300(dev_priv)) {
			disp_output_cntl = RADEON_READ(RADEON_DISP_OUTPUT_CNTL) &
				~(RADEON_DISP_DAC_SOURCE_MASK);
			RADEON_WRITE(RADEON_DISP_OUTPUT_CNTL, disp_output_cntl);
		} else {
			dac2_cntl = RADEON_READ(RADEON_DAC_CNTL2)  & ~(RADEON_DAC2_DAC_CLK_SEL);
			RADEON_WRITE(RADEON_DAC_CNTL2, dac2_cntl);
		}
	} else {
		if (dev_priv->chip_family == CHIP_R200 || radeon_is_r300(dev_priv)) {
			disp_output_cntl = RADEON_READ(RADEON_DISP_OUTPUT_CNTL) &
				~(RADEON_DISP_DAC_SOURCE_MASK);
			disp_output_cntl |= RADEON_DISP_DAC_SOURCE_CRTC2;
			RADEON_WRITE(RADEON_DISP_OUTPUT_CNTL, disp_output_cntl);
		} else {
			dac2_cntl = RADEON_READ(RADEON_DAC_CNTL2) | RADEON_DAC2_DAC_CLK_SEL;
			RADEON_WRITE(RADEON_DAC_CNTL2, dac2_cntl);
		}
	}

	dac_cntl = (RADEON_DAC_MASK_ALL |
		    RADEON_DAC_VGA_ADR_EN |
		    /* TODO 6-bits */
		    RADEON_DAC_8BIT_EN);

	RADEON_WRITE_P(RADEON_DAC_CNTL,
		       dac_cntl,
		       RADEON_DAC_RANGE_CNTL |
		       RADEON_DAC_BLANKING);

	if (radeon_encoder->ps2_pdac_adj)
		dac_macro_cntl = radeon_encoder->ps2_pdac_adj;
	else
		dac_macro_cntl = RADEON_READ(RADEON_DAC_MACRO_CNTL);
	dac_macro_cntl |= RADEON_DAC_PDWN_R | RADEON_DAC_PDWN_G | RADEON_DAC_PDWN_B;
	RADEON_WRITE(RADEON_DAC_MACRO_CNTL, dac_macro_cntl);
}

static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_encoder *encoder,
								  struct drm_connector *connector)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	uint32_t vclk_ecp_cntl, crtc_ext_cntl;
	uint32_t dac_ext_cntl, dac_cntl, dac_macro_cntl, tmp;
	enum drm_connector_status found = connector_status_disconnected;
	bool color = true;

	/* save the regs we need */
	vclk_ecp_cntl = RADEON_READ_PLL(dev_priv, RADEON_VCLK_ECP_CNTL);
	crtc_ext_cntl = RADEON_READ(RADEON_CRTC_EXT_CNTL);
	dac_ext_cntl = RADEON_READ(RADEON_DAC_EXT_CNTL);
	dac_cntl = RADEON_READ(RADEON_DAC_CNTL);
	dac_macro_cntl = RADEON_READ(RADEON_DAC_MACRO_CNTL);

	tmp = vclk_ecp_cntl &
		~(RADEON_PIXCLK_ALWAYS_ONb | RADEON_PIXCLK_DAC_ALWAYS_ONb);
	RADEON_WRITE_PLL(dev_priv, RADEON_VCLK_ECP_CNTL, tmp);

	tmp = crtc_ext_cntl | RADEON_CRTC_CRT_ON;
	RADEON_WRITE(RADEON_CRTC_EXT_CNTL, tmp);

	tmp = RADEON_DAC_FORCE_BLANK_OFF_EN |
		RADEON_DAC_FORCE_DATA_EN;

	if (color)
		tmp |= RADEON_DAC_FORCE_DATA_SEL_RGB;
	else
		tmp |= RADEON_DAC_FORCE_DATA_SEL_G;

	if (radeon_is_r300(dev_priv))
		tmp |= (0x1b6 << RADEON_DAC_FORCE_DATA_SHIFT);
	else
		tmp |= (0x180 << RADEON_DAC_FORCE_DATA_SHIFT);

	RADEON_WRITE(RADEON_DAC_EXT_CNTL, tmp);

	tmp = dac_cntl & ~(RADEON_DAC_RANGE_CNTL_MASK | RADEON_DAC_PDWN);
	tmp |= RADEON_DAC_RANGE_CNTL_PS2 | RADEON_DAC_CMP_EN;
	RADEON_WRITE(RADEON_DAC_CNTL, tmp);

	tmp &= ~(RADEON_DAC_PDWN_R |
		 RADEON_DAC_PDWN_G |
		 RADEON_DAC_PDWN_B);

	RADEON_WRITE(RADEON_DAC_MACRO_CNTL, tmp);

	udelay(2000);

	if (RADEON_READ(RADEON_DAC_CNTL) & RADEON_DAC_CMP_OUTPUT)
		found = connector_status_connected;

	/* restore the regs we used */
	RADEON_WRITE(RADEON_DAC_CNTL, dac_cntl);
	RADEON_WRITE(RADEON_DAC_MACRO_CNTL, dac_macro_cntl);
	RADEON_WRITE(RADEON_DAC_EXT_CNTL, dac_ext_cntl);
	RADEON_WRITE(RADEON_CRTC_EXT_CNTL, crtc_ext_cntl);
	RADEON_WRITE_PLL(dev_priv, RADEON_VCLK_ECP_CNTL, vclk_ecp_cntl);

	return found;
}

static const struct drm_encoder_helper_funcs radeon_legacy_primary_dac_helper_funcs = {
	.dpms = radeon_legacy_primary_dac_dpms,
	.mode_fixup = radeon_legacy_primary_dac_mode_fixup,
	.prepare = radeon_legacy_primary_dac_prepare,
	.mode_set = radeon_legacy_primary_dac_mode_set,
	.commit = radeon_legacy_primary_dac_commit,
	.detect = radeon_legacy_primary_dac_detect,
};


static const struct drm_encoder_funcs radeon_legacy_primary_dac_enc_funcs = {
	.destroy = radeon_enc_destroy,
};

struct drm_encoder *radeon_encoder_legacy_primary_dac_add(struct drm_device *dev, int bios_index, int has_tv)
{
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_encoder *radeon_encoder;
	struct drm_encoder *encoder;

	DRM_DEBUG("\n");

	radeon_encoder = kzalloc(sizeof(struct radeon_encoder), GFP_KERNEL);
	if (!radeon_encoder) {
		return NULL;
	}

	encoder = &radeon_encoder->base;

	encoder->possible_crtcs = 0x3;
	encoder->possible_clones = 0;
	drm_encoder_init(dev, encoder, &radeon_legacy_primary_dac_enc_funcs,
			 DRM_MODE_ENCODER_DAC);

	drm_encoder_helper_add(encoder, &radeon_legacy_primary_dac_helper_funcs);

	/* get the primary dac bg/adj vals from bios tables */
	if (!dev_priv->is_atom_bios)
		radeon_combios_get_primary_dac_info(radeon_encoder);

	return encoder;
}


static bool radeon_legacy_tmds_int_mode_fixup(struct drm_encoder *encoder,
					      struct drm_display_mode *mode,
					      struct drm_display_mode *adjusted_mode)
{
	return true;
}

static void radeon_legacy_tmds_int_dpms(struct drm_encoder *encoder, int mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_crtc *radeon_crtc;
	uint32_t fp_gen_cntl = RADEON_READ(RADEON_FP_GEN_CNTL);
	uint32_t bios_5_scratch, bios_6_scratch;
	int crtc_id = 0;
	DRM_DEBUG("\n");

	if (encoder->crtc) {
		radeon_crtc = to_radeon_crtc(encoder->crtc);
		crtc_id = radeon_crtc->crtc_id;
	}

	// FIXME atom/legacy cards like r4xx
	bios_5_scratch = RADEON_READ(RADEON_BIOS_5_SCRATCH);
	bios_6_scratch = RADEON_READ(RADEON_BIOS_6_SCRATCH);

	bios_5_scratch &= ~RADEON_DFP1_CRTC_MASK;
	bios_5_scratch |= (crtc_id << RADEON_DFP1_CRTC_SHIFT);

	switch(mode) {
	case DRM_MODE_DPMS_ON:
                fp_gen_cntl |= (RADEON_FP_FPON | RADEON_FP_TMDS_EN);
		bios_5_scratch |= RADEON_DFP1_ON;
		bios_6_scratch |= RADEON_DFP_DPMS_ON;
		break;
	case DRM_MODE_DPMS_STANDBY:
	case DRM_MODE_DPMS_SUSPEND:
	case DRM_MODE_DPMS_OFF:
		fp_gen_cntl &= ~(RADEON_FP_FPON | RADEON_FP_TMDS_EN);
		bios_5_scratch &= ~RADEON_DFP1_ON;
		bios_6_scratch &= ~RADEON_DFP_DPMS_ON;
		break;
	}

	RADEON_WRITE(RADEON_FP_GEN_CNTL, fp_gen_cntl);

	RADEON_WRITE(RADEON_BIOS_5_SCRATCH, bios_5_scratch);
	RADEON_WRITE(RADEON_BIOS_6_SCRATCH, bios_6_scratch);
}

static void radeon_legacy_tmds_int_prepare(struct drm_encoder *encoder)
{
	struct drm_radeon_private *dev_priv = encoder->dev->dev_private;
	// fix me: atom/legacy r4xx
	if (!dev_priv->is_atom_bios)
		radeon_combios_output_lock(encoder, true);
	radeon_legacy_tmds_int_dpms(encoder, DRM_MODE_DPMS_OFF);
}

static void radeon_legacy_tmds_int_commit(struct drm_encoder *encoder)
{
	struct drm_radeon_private *dev_priv = encoder->dev->dev_private;
	radeon_legacy_tmds_int_dpms(encoder, DRM_MODE_DPMS_ON);
	// fix me: atom/legacy r4xx
	if (!dev_priv->is_atom_bios)
		radeon_combios_output_lock(encoder, true);
}

static void radeon_legacy_tmds_int_mode_set(struct drm_encoder *encoder,
					    struct drm_display_mode *mode,
					    struct drm_display_mode *adjusted_mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_crtc *radeon_crtc = to_radeon_crtc(encoder->crtc);
	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
	uint32_t tmp, tmds_pll_cntl, tmds_transmitter_cntl, fp_gen_cntl;
	int i;

	DRM_DEBUG("\n");

	if (radeon_crtc->crtc_id == 0)
		radeon_legacy_rmx_mode_set(encoder, mode, adjusted_mode);

	tmp = tmds_pll_cntl = RADEON_READ(RADEON_TMDS_PLL_CNTL);
	tmp &= 0xfffff;
	if (dev_priv->chip_family == CHIP_RV280) {
		/* bit 22 of TMDS_PLL_CNTL is read-back inverted */
		tmp ^= (1 << 22);
		tmds_pll_cntl ^= (1 << 22);
	}

	for (i = 0; i < 4; i++) {
		if (radeon_encoder->tmds_pll[i].freq == 0)
			break;
		if ((uint32_t)(mode->clock / 10) < radeon_encoder->tmds_pll[i].freq) {
			tmp = radeon_encoder->tmds_pll[i].value ;
			break;
		}
	}

	if (radeon_is_r300(dev_priv) || (dev_priv->chip_family == CHIP_RV280)) {
		if (tmp & 0xfff00000)
			tmds_pll_cntl = tmp;
		else {
			tmds_pll_cntl &= 0xfff00000;
			tmds_pll_cntl |= tmp;
		}
	} else
		tmds_pll_cntl = tmp;

	tmds_transmitter_cntl = RADEON_READ(RADEON_TMDS_TRANSMITTER_CNTL) &
		~(RADEON_TMDS_TRANSMITTER_PLLRST);

    if (dev_priv->chip_family == CHIP_R200 ||
	dev_priv->chip_family == CHIP_R100 ||
	radeon_is_r300(dev_priv))
	    tmds_transmitter_cntl &= ~(RADEON_TMDS_TRANSMITTER_PLLEN);
    else /* RV chips got this bit reversed */
	    tmds_transmitter_cntl |= RADEON_TMDS_TRANSMITTER_PLLEN;

    fp_gen_cntl = (RADEON_READ(RADEON_FP_GEN_CNTL) |
		   (RADEON_FP_CRTC_DONT_SHADOW_VPAR |
		    RADEON_FP_CRTC_DONT_SHADOW_HEND));

    fp_gen_cntl &= ~(RADEON_FP_FPON | RADEON_FP_TMDS_EN);

    if (1) // FIXME rgbBits == 8
	    fp_gen_cntl |= RADEON_FP_PANEL_FORMAT;  /* 24 bit format */
    else
	    fp_gen_cntl &= ~RADEON_FP_PANEL_FORMAT;/* 18 bit format */

    if (radeon_crtc->crtc_id == 0) {
	    if (radeon_is_r300(dev_priv) || dev_priv->chip_family == CHIP_R200) {
		    fp_gen_cntl &= ~R200_FP_SOURCE_SEL_MASK;
		    if (radeon_encoder->flags & RADEON_USE_RMX)
			    fp_gen_cntl |= R200_FP_SOURCE_SEL_RMX;
		    else
			    fp_gen_cntl |= R200_FP_SOURCE_SEL_CRTC1;
	    } else
		    fp_gen_cntl |= RADEON_FP_SEL_CRTC1;
    } else {
	    if (radeon_is_r300(dev_priv) || dev_priv->chip_family == CHIP_R200) {
		    fp_gen_cntl &= ~R200_FP_SOURCE_SEL_MASK;
		    fp_gen_cntl |= R200_FP_SOURCE_SEL_CRTC2;
	    } else
		    fp_gen_cntl |= RADEON_FP_SEL_CRTC2;
    }

    RADEON_WRITE(RADEON_TMDS_PLL_CNTL, tmds_pll_cntl);
    RADEON_WRITE(RADEON_TMDS_TRANSMITTER_CNTL, tmds_transmitter_cntl);
    RADEON_WRITE(RADEON_FP_GEN_CNTL, fp_gen_cntl);
}

static const struct drm_encoder_helper_funcs radeon_legacy_tmds_int_helper_funcs = {
	.dpms = radeon_legacy_tmds_int_dpms,
	.mode_fixup = radeon_legacy_tmds_int_mode_fixup,
	.prepare = radeon_legacy_tmds_int_prepare,
	.mode_set = radeon_legacy_tmds_int_mode_set,
	.commit = radeon_legacy_tmds_int_commit,
};


static const struct drm_encoder_funcs radeon_legacy_tmds_int_enc_funcs = {
	.destroy = radeon_enc_destroy,
};

struct drm_encoder *radeon_encoder_legacy_tmds_int_add(struct drm_device *dev, int bios_index)
{
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_encoder *radeon_encoder;
	struct drm_encoder *encoder;

	DRM_DEBUG("\n");

	radeon_encoder = kzalloc(sizeof(struct radeon_encoder), GFP_KERNEL);
	if (!radeon_encoder) {
		return NULL;
	}

	encoder = &radeon_encoder->base;

	encoder->possible_crtcs = 0x3;
	encoder->possible_clones = 0;
	drm_encoder_init(dev, encoder, &radeon_legacy_tmds_int_enc_funcs,
			 DRM_MODE_ENCODER_TMDS);

	drm_encoder_helper_add(encoder, &radeon_legacy_tmds_int_helper_funcs);

	if (dev_priv->is_atom_bios)
		radeon_atombios_get_tmds_info(radeon_encoder);
	else
		radeon_combios_get_tmds_info(radeon_encoder);

	return encoder;
}

static bool radeon_legacy_tmds_ext_mode_fixup(struct drm_encoder *encoder,
					      struct drm_display_mode *mode,
					      struct drm_display_mode *adjusted_mode)
{
	return true;
}

static void radeon_legacy_tmds_ext_dpms(struct drm_encoder *encoder, int mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_crtc *radeon_crtc;
	uint32_t fp2_gen_cntl = RADEON_READ(RADEON_FP2_GEN_CNTL);
	uint32_t bios_5_scratch, bios_6_scratch;
	int crtc_id = 0;
	DRM_DEBUG("\n");

	if (encoder->crtc) {
		radeon_crtc = to_radeon_crtc(encoder->crtc);
		crtc_id = radeon_crtc->crtc_id;
	}

	// FIXME atom/legacy cards like r4xx
	bios_5_scratch = RADEON_READ(RADEON_BIOS_5_SCRATCH);
	bios_6_scratch = RADEON_READ(RADEON_BIOS_6_SCRATCH);

	bios_5_scratch &= ~RADEON_DFP2_CRTC_MASK;
	bios_5_scratch |= (crtc_id << RADEON_DFP2_CRTC_SHIFT);

	switch(mode) {
	case DRM_MODE_DPMS_ON:
		fp2_gen_cntl &= ~RADEON_FP2_BLANK_EN;
		fp2_gen_cntl |= (RADEON_FP2_ON | RADEON_FP2_DVO_EN);
		bios_5_scratch |= RADEON_DFP2_ON;
		bios_6_scratch |= RADEON_DFP_DPMS_ON;
		break;
	case DRM_MODE_DPMS_STANDBY:
	case DRM_MODE_DPMS_SUSPEND:
	case DRM_MODE_DPMS_OFF:
		fp2_gen_cntl |= RADEON_FP2_BLANK_EN;
		fp2_gen_cntl &= ~(RADEON_FP2_ON | RADEON_FP2_DVO_EN);
		bios_5_scratch &= ~RADEON_DFP2_ON;
		bios_6_scratch &= ~RADEON_DFP_DPMS_ON;
		break;
	}

	RADEON_WRITE(RADEON_FP2_GEN_CNTL, fp2_gen_cntl);

	RADEON_WRITE(RADEON_BIOS_5_SCRATCH, bios_5_scratch);
	RADEON_WRITE(RADEON_BIOS_6_SCRATCH, bios_6_scratch);
}

static void radeon_legacy_tmds_ext_prepare(struct drm_encoder *encoder)
{
	struct drm_radeon_private *dev_priv = encoder->dev->dev_private;
	// fix me: atom/legacy r4xx
	if (!dev_priv->is_atom_bios)
		radeon_combios_output_lock(encoder, true);
	radeon_legacy_tmds_ext_dpms(encoder, DRM_MODE_DPMS_OFF);
}

static void radeon_legacy_tmds_ext_commit(struct drm_encoder *encoder)
{
	struct drm_radeon_private *dev_priv = encoder->dev->dev_private;
	radeon_legacy_tmds_ext_dpms(encoder, DRM_MODE_DPMS_ON);
	// fix me: atom/legacy r4xx
	if (!dev_priv->is_atom_bios)
		radeon_combios_output_lock(encoder, false);
}

static void radeon_legacy_tmds_ext_mode_set(struct drm_encoder *encoder,
					    struct drm_display_mode *mode,
					    struct drm_display_mode *adjusted_mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_crtc *radeon_crtc = to_radeon_crtc(encoder->crtc);
	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
	uint32_t fp2_gen_cntl = RADEON_READ(RADEON_FP2_GEN_CNTL);

	DRM_DEBUG("\n");

	if (radeon_crtc->crtc_id == 0)
		radeon_legacy_rmx_mode_set(encoder, mode, adjusted_mode);

	if (1) // FIXME rgbBits == 8
		fp2_gen_cntl |= RADEON_FP2_PANEL_FORMAT; /* 24 bit format, */
	else
		fp2_gen_cntl &= ~RADEON_FP2_PANEL_FORMAT;/* 18 bit format, */

	fp2_gen_cntl &= ~(RADEON_FP2_ON |
			  RADEON_FP2_DVO_EN |
			  RADEON_FP2_DVO_RATE_SEL_SDR);

	/* XXX: these are oem specific */
	if (radeon_is_r300(dev_priv)) {
		if ((dev->pdev->device == 0x4850) &&
		    (dev->pdev->subsystem_vendor == 0x1028) &&
		    (dev->pdev->subsystem_device == 0x2001)) /* Dell Inspiron 8600 */
			fp2_gen_cntl |= R300_FP2_DVO_CLOCK_MODE_SINGLE;
		else
			fp2_gen_cntl |= RADEON_FP2_PAD_FLOP_EN | R300_FP2_DVO_CLOCK_MODE_SINGLE;

		/*if (mode->clock > 165000)
			fp2_gen_cntl |= R300_FP2_DVO_DUAL_CHANNEL_EN;*/
	}

	if (radeon_crtc->crtc_id == 0) {
		if ((dev_priv->chip_family == CHIP_R200) || radeon_is_r300(dev_priv)) {
			fp2_gen_cntl &= ~R200_FP2_SOURCE_SEL_MASK;
			if (radeon_encoder->flags & RADEON_USE_RMX)
				fp2_gen_cntl |= R200_FP2_SOURCE_SEL_RMX;
			else
				fp2_gen_cntl |= R200_FP2_SOURCE_SEL_CRTC1;
		} else
			fp2_gen_cntl &= ~RADEON_FP2_SRC_SEL_CRTC2;
	} else {
		if ((dev_priv->chip_family == CHIP_R200) || radeon_is_r300(dev_priv)) {
			fp2_gen_cntl &= ~R200_FP2_SOURCE_SEL_MASK;
			fp2_gen_cntl |= R200_FP2_SOURCE_SEL_CRTC2;
		} else
			fp2_gen_cntl |= RADEON_FP2_SRC_SEL_CRTC2;
	}

	RADEON_WRITE(RADEON_FP2_GEN_CNTL, fp2_gen_cntl);
}

static const struct drm_encoder_helper_funcs radeon_legacy_tmds_ext_helper_funcs = {
	.dpms = radeon_legacy_tmds_ext_dpms,
	.mode_fixup = radeon_legacy_tmds_ext_mode_fixup,
	.prepare = radeon_legacy_tmds_ext_prepare,
	.mode_set = radeon_legacy_tmds_ext_mode_set,
	.commit = radeon_legacy_tmds_ext_commit,
};


static const struct drm_encoder_funcs radeon_legacy_tmds_ext_enc_funcs = {
	.destroy = radeon_enc_destroy,
};

struct drm_encoder *radeon_encoder_legacy_tmds_ext_add(struct drm_device *dev, int bios_index)
{
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_encoder *radeon_encoder;
	struct drm_encoder *encoder;

	DRM_DEBUG("\n");

	radeon_encoder = kzalloc(sizeof(struct radeon_encoder), GFP_KERNEL);
	if (!radeon_encoder) {
		return NULL;
	}

	encoder = &radeon_encoder->base;

	encoder->possible_crtcs = 0x3;
	encoder->possible_clones = 0;
	drm_encoder_init(dev, encoder, &radeon_legacy_tmds_ext_enc_funcs,
			 DRM_MODE_ENCODER_TMDS);

	drm_encoder_helper_add(encoder, &radeon_legacy_tmds_ext_helper_funcs);

	if (!dev_priv->is_atom_bios)
		radeon_combios_get_ext_tmds_info(radeon_encoder);
	return encoder;
}

static bool radeon_legacy_tv_dac_mode_fixup(struct drm_encoder *encoder,
					    struct drm_display_mode *mode,
					    struct drm_display_mode *adjusted_mode)
{
	return true;
}

static void radeon_legacy_tv_dac_dpms(struct drm_encoder *encoder, int mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_crtc *radeon_crtc;
	uint32_t fp2_gen_cntl = 0, crtc2_gen_cntl = 0, tv_dac_cntl = 0;
	//uint32_t tv_master_cntl = 0;
	uint32_t bios_5_scratch, bios_6_scratch;
	int crtc_id = 0;

	DRM_DEBUG("\n");

	if (encoder->crtc) {
		radeon_crtc = to_radeon_crtc(encoder->crtc);
		crtc_id = radeon_crtc->crtc_id;
	}

	// FIXME atom/legacy cards like r4xx
	bios_5_scratch = RADEON_READ(RADEON_BIOS_5_SCRATCH);
	bios_6_scratch = RADEON_READ(RADEON_BIOS_6_SCRATCH);

	bios_5_scratch &= ~RADEON_CRT2_CRTC_MASK;
	bios_5_scratch |= (crtc_id << RADEON_CRT2_CRTC_SHIFT);
	// FIXME TV
	//bios_5_scratch &= ~RADEON_TV1_CRTC_MASK;
	//bios_5_scratch |= (crtc_id << RADEON_TV1_CRTC_SHIFT);

	if (dev_priv->chip_family == CHIP_R200)
		fp2_gen_cntl = RADEON_READ(RADEON_FP2_GEN_CNTL);
	else {
		crtc2_gen_cntl = RADEON_READ(RADEON_CRTC2_GEN_CNTL);
		// FIXME TV
		//tv_master_cntl = RADEON_READ(RADEON_TV_MASTER_CNTL);
		tv_dac_cntl = RADEON_READ(RADEON_TV_DAC_CNTL);
	}

	switch(mode) {
	case DRM_MODE_DPMS_ON:
                if (dev_priv->chip_family == CHIP_R200)
			fp2_gen_cntl |= (RADEON_FP2_ON | RADEON_FP2_DVO_EN);
                else {
			crtc2_gen_cntl |= RADEON_CRTC2_CRT2_ON;
			//tv_master_cntl |= RADEON_TV_ON;
			if (dev_priv->chip_family == CHIP_R420 ||
			    dev_priv->chip_family == CHIP_RV410)
				tv_dac_cntl &= ~(R420_TV_DAC_RDACPD |
						 R420_TV_DAC_GDACPD |
						 R420_TV_DAC_BDACPD |
						 RADEON_TV_DAC_BGSLEEP);
			else
				tv_dac_cntl &= ~(RADEON_TV_DAC_RDACPD |
						 RADEON_TV_DAC_GDACPD |
						 RADEON_TV_DAC_BDACPD |
						 RADEON_TV_DAC_BGSLEEP);
		}
		//bios_5_scratch |= RADEON_TV1_ON;
		//bios_6_scratch |= RADEON_TV_DPMS_ON;
		bios_5_scratch |= RADEON_CRT2_ON;
		bios_6_scratch |= RADEON_CRT_DPMS_ON;
		break;
	case DRM_MODE_DPMS_STANDBY:
	case DRM_MODE_DPMS_SUSPEND:
	case DRM_MODE_DPMS_OFF:
		if (dev_priv->chip_family == CHIP_R200)
                        fp2_gen_cntl &= ~(RADEON_FP2_ON | RADEON_FP2_DVO_EN);
		else {
                        crtc2_gen_cntl &= ~RADEON_CRTC2_CRT2_ON;
			//tv_master_cntl &= ~RADEON_TV_ON;
			if (dev_priv->chip_family == CHIP_R420 ||
			    dev_priv->chip_family == CHIP_RV410)
				tv_dac_cntl |= (R420_TV_DAC_RDACPD |
						R420_TV_DAC_GDACPD |
						R420_TV_DAC_BDACPD |
						RADEON_TV_DAC_BGSLEEP);
			else
				tv_dac_cntl |= (RADEON_TV_DAC_RDACPD |
						RADEON_TV_DAC_GDACPD |
						RADEON_TV_DAC_BDACPD |
						RADEON_TV_DAC_BGSLEEP);
		}
		//bios_5_scratch &= ~RADEON_TV1_ON;
		//bios_6_scratch &= ~RADEON_TV_DPMS_ON;
		bios_5_scratch &= ~RADEON_CRT2_ON;
		bios_6_scratch &= ~RADEON_CRT_DPMS_ON;
		break;
	}

	if (dev_priv->chip_family == CHIP_R200)
		RADEON_WRITE(RADEON_FP2_GEN_CNTL, fp2_gen_cntl);
	else {
		RADEON_WRITE(RADEON_CRTC2_GEN_CNTL, crtc2_gen_cntl);
		//RADEON_WRITE(RADEON_TV_MASTER_CNTL, tv_master_cntl);
		RADEON_WRITE(RADEON_TV_DAC_CNTL, tv_dac_cntl);
	}

	RADEON_WRITE(RADEON_BIOS_5_SCRATCH, bios_5_scratch);
	RADEON_WRITE(RADEON_BIOS_6_SCRATCH, bios_6_scratch);
}

static void radeon_legacy_tv_dac_prepare(struct drm_encoder *encoder)
{
	// fix me: atom/legacy r4xx
	radeon_combios_output_lock(encoder, true);
	radeon_legacy_tv_dac_dpms(encoder, DRM_MODE_DPMS_OFF);
}

static void radeon_legacy_tv_dac_commit(struct drm_encoder *encoder)
{
	radeon_legacy_tv_dac_dpms(encoder, DRM_MODE_DPMS_ON);
	// fix me: atom/legacy r4xx
	radeon_combios_output_lock(encoder, false);
}

static void radeon_legacy_tv_dac_mode_set(struct drm_encoder *encoder,
					  struct drm_display_mode *mode,
					  struct drm_display_mode *adjusted_mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	struct radeon_crtc *radeon_crtc = to_radeon_crtc(encoder->crtc);
	struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
	uint32_t tv_dac_cntl, gpiopad_a = 0, dac2_cntl, disp_output_cntl = 0;
	uint32_t disp_hw_debug = 0, fp2_gen_cntl = 0;

	DRM_DEBUG("\n");

	if (radeon_crtc->crtc_id == 0)
		radeon_legacy_rmx_mode_set(encoder, mode, adjusted_mode);

	if (dev_priv->chip_family != CHIP_R200) {
		tv_dac_cntl = RADEON_READ(RADEON_TV_DAC_CNTL);
		if (dev_priv->chip_family == CHIP_R420 ||
		    dev_priv->chip_family == CHIP_RV410) {
			tv_dac_cntl &= ~(RADEON_TV_DAC_STD_MASK |
					 RADEON_TV_DAC_BGADJ_MASK |
					 R420_TV_DAC_DACADJ_MASK |
					 R420_TV_DAC_RDACPD |
					 R420_TV_DAC_GDACPD |
					 R420_TV_DAC_GDACPD |
					 R420_TV_DAC_TVENABLE);
		} else {
			tv_dac_cntl &= ~(RADEON_TV_DAC_STD_MASK |
					 RADEON_TV_DAC_BGADJ_MASK |
					 RADEON_TV_DAC_DACADJ_MASK |
					 RADEON_TV_DAC_RDACPD |
					 RADEON_TV_DAC_GDACPD |
					 RADEON_TV_DAC_GDACPD);
		}

		// FIXME TV
		tv_dac_cntl |= (RADEON_TV_DAC_NBLANK |
				RADEON_TV_DAC_NHOLD |
				RADEON_TV_DAC_STD_PS2 |
				radeon_encoder->ps2_tvdac_adj);

		RADEON_WRITE(RADEON_TV_DAC_CNTL, tv_dac_cntl);
	}

	if (radeon_is_r300(dev_priv)) {
		gpiopad_a = RADEON_READ(RADEON_GPIOPAD_A) | 1;
		disp_output_cntl = RADEON_READ(RADEON_DISP_OUTPUT_CNTL);
	} else if (dev_priv->chip_family == CHIP_R200)
		fp2_gen_cntl = RADEON_READ(RADEON_FP2_GEN_CNTL);
	else
		disp_hw_debug = RADEON_READ(RADEON_DISP_HW_DEBUG);

	dac2_cntl = RADEON_READ(RADEON_DAC_CNTL2) | RADEON_DAC2_DAC2_CLK_SEL;

	if (radeon_crtc->crtc_id == 0) {
		if (radeon_is_r300(dev_priv)) {
			disp_output_cntl &= ~RADEON_DISP_TVDAC_SOURCE_MASK;
			disp_output_cntl |= RADEON_DISP_TVDAC_SOURCE_CRTC;
		} else if (dev_priv->chip_family == CHIP_R200) {
			fp2_gen_cntl &= ~(R200_FP2_SOURCE_SEL_MASK |
					  RADEON_FP2_DVO_RATE_SEL_SDR);
		} else
			disp_hw_debug |= RADEON_CRT2_DISP1_SEL;
	} else {
		if (radeon_is_r300(dev_priv)) {
			disp_output_cntl &= ~RADEON_DISP_TVDAC_SOURCE_MASK;
			disp_output_cntl |= RADEON_DISP_TVDAC_SOURCE_CRTC2;
		} else if (dev_priv->chip_family == CHIP_R200) {
			fp2_gen_cntl &= ~(R200_FP2_SOURCE_SEL_MASK |
					  RADEON_FP2_DVO_RATE_SEL_SDR);
			fp2_gen_cntl |= R200_FP2_SOURCE_SEL_CRTC2;
		} else
			disp_hw_debug &= ~RADEON_CRT2_DISP1_SEL;
	}

	RADEON_WRITE(RADEON_DAC_CNTL2, dac2_cntl);

	if (radeon_is_r300(dev_priv)) {
		RADEON_WRITE_P(RADEON_GPIOPAD_A, gpiopad_a, ~1);
		RADEON_WRITE(RADEON_DISP_TV_OUT_CNTL, disp_output_cntl);
	} else if (dev_priv->chip_family == CHIP_R200)
		RADEON_WRITE(RADEON_FP2_GEN_CNTL, fp2_gen_cntl);
	else
		RADEON_WRITE(RADEON_DISP_HW_DEBUG, disp_hw_debug);

}

static enum drm_connector_status radeon_legacy_tv_dac_detect(struct drm_encoder *encoder,
							     struct drm_connector *connector)
{
	struct drm_device *dev = encoder->dev;
	struct drm_radeon_private *dev_priv = dev->dev_private;
	uint32_t crtc2_gen_cntl, tv_dac_cntl, dac_cntl2, dac_ext_cntl;
	uint32_t disp_hw_debug, disp_output_cntl, gpiopad_a, pixclks_cntl, tmp;
	enum drm_connector_status found = connector_status_disconnected;
	bool color = true;

	// FIXME tv

	/* save the regs we need */
	pixclks_cntl = RADEON_READ_PLL(dev_priv, RADEON_PIXCLKS_CNTL);
	gpiopad_a = radeon_is_r300(dev_priv) ? RADEON_READ(RADEON_GPIOPAD_A) : 0;
	disp_output_cntl = radeon_is_r300(dev_priv) ? RADEON_READ(RADEON_DISP_OUTPUT_CNTL) : 0;