From d785a753f9406bf74150e038ccf58b8b40eea932 Mon Sep 17 00:00:00 2001 From: Tomi Valkeinen Date: Sat, 13 Sep 2025 17:43:53 +0300 Subject: fix: Resolve variable shadowing warnings Fix cppcheck shadowVariable and shadowArgument warnings by renaming local variables to avoid conflicts: - Rename 'ob' to 'prop' in property creation loop in card.cpp - Rename loop variable 'y_offset' to 'y_off' in conv-yuv-semiplanar.h - Rename local 'y' to 'y_val' in SMPTE pattern generator in testpat.cpp - Rename 'is_last' to 'child_is_last' in entry printing in kmsprint.cpp These changes eliminate naming conflicts while preserving functionality and improving code clarity. --- kms++util/src/conv-yuv-semiplanar.h | 6 +++--- kms++util/src/testpat.cpp | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'kms++util/src') diff --git a/kms++util/src/conv-yuv-semiplanar.h b/kms++util/src/conv-yuv-semiplanar.h index 3c4eec2..f9d771d 100644 --- a/kms++util/src/conv-yuv-semiplanar.h +++ b/kms++util/src/conv-yuv-semiplanar.h @@ -121,10 +121,10 @@ public: if (y_offset == 0) { // Fill line buffers - for (size_t y_offset = 0; y_offset < v_sub; y_offset++) { - auto line = md::submdspan(linebuf, y_offset, md::full_extent); + for (size_t y_off = 0; y_off < v_sub; y_off++) { + auto line = md::submdspan(linebuf, y_off, md::full_extent); std::span span(line.data_handle(), line.size()); - generate_line(y_src + y_offset, span); + generate_line(y_src + y_off, span); } } diff --git a/kms++util/src/testpat.cpp b/kms++util/src/testpat.cpp index 7984de8..1edf978 100644 --- a/kms++util/src/testpat.cpp +++ b/kms++util/src/testpat.cpp @@ -201,8 +201,8 @@ static YUV16 get_smpte_pixel(size_t w, size_t h, size_t x, size_t y) const size_t ramp_width = a - 2 * d; const size_t ramp_x = x - d; - uint16_t y = 256 + (3760 - 256) * ramp_x / ramp_width; - return YUV16::from_12(y, 2048, 2048); + uint16_t y_val = 256 + (3760 - 256) * ramp_x / ramp_width; + return YUV16::from_12(y_val, 2048, 2048); } // Pattern 4 (PLUGE) -- cgit v1.2.3