From 7a4e4cbf5e70cd304b751f9862792e0d6af85eb1 Mon Sep 17 00:00:00 2001
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Date: Mon, 21 Apr 2025 22:01:07 +0300
Subject: Fix a few clang warnings

---
 kms++/src/crtc.cpp   | 8 ++++----
 kmscube/cube-egl.cpp | 4 ++--
 utils/kmstest.cpp    | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/kms++/src/crtc.cpp b/kms++/src/crtc.cpp
index 1c1888f..d217863 100644
--- a/kms++/src/crtc.cpp
+++ b/kms++/src/crtc.cpp
@@ -181,9 +181,9 @@ int Crtc::legacy_gamma_size() const
 void Crtc::legacy_gamma_set(vector<tuple<uint16_t, uint16_t, uint16_t>> v)
 {
 	uint32_t len = v.size();
-	uint16_t red[len];
-	uint16_t green[len];
-	uint16_t blue[len];
+	vector<uint16_t> red(len);
+	vector<uint16_t> green(len);
+	vector<uint16_t> blue(len);
 
 	for (uint32_t i = 0; i < len; ++i) {
 		red[i] = get<0>(v[i]);
@@ -191,7 +191,7 @@ void Crtc::legacy_gamma_set(vector<tuple<uint16_t, uint16_t, uint16_t>> v)
 		blue[i] = get<2>(v[i]);
 	}
 
-	drmModeCrtcSetGamma(card().fd(), id(), len, red, green, blue);
+	drmModeCrtcSetGamma(card().fd(), id(), len, red.data(), green.data(), blue.data());
 }
 
 } // namespace kms
diff --git a/kmscube/cube-egl.cpp b/kmscube/cube-egl.cpp
index 372c978..3ff6ea9 100644
--- a/kmscube/cube-egl.cpp
+++ b/kmscube/cube-egl.cpp
@@ -68,8 +68,8 @@ EglState::EglState(void* native_display, EGLint native_visual_id)
 	FAIL_IF(!b, "failed to get number of configs");
 
 	if (s_verbose) {
-		EGLConfig configs[numConfigs];
-		b = eglGetConfigs(m_display, configs, numConfigs, &numConfigs);
+		vector<EGLConfig> configs(numConfigs);
+		b = eglGetConfigs(m_display, configs.data(), numConfigs, &numConfigs);
 		FAIL_IF(!b, "failed to get configs");
 
 		printf("Available configs:\n");
diff --git a/utils/kmstest.cpp b/utils/kmstest.cpp
index c6cf129..43dc355 100644
--- a/utils/kmstest.cpp
+++ b/utils/kmstest.cpp
@@ -1118,7 +1118,7 @@ static void main_flip(Card& card, const vector<OutputInfo>& outputs)
 	if (!s_flip_sync) {
 		for (const OutputInfo& o : outputs) {
 			auto fs = unique_ptr<FlipState>(new FlipState(card, to_string(o.connector->idx()), { &o }));
-			flipstates.push_back(move(fs));
+			flipstates.push_back(std::move(fs));
 		}
 	} else {
 		vector<const OutputInfo*> ois;
@@ -1130,7 +1130,7 @@ static void main_flip(Card& card, const vector<OutputInfo>& outputs)
 		}
 
 		auto fs = unique_ptr<FlipState>(new FlipState(card, name, ois));
-		flipstates.push_back(move(fs));
+		flipstates.push_back(std::move(fs));
 	}
 
 	for (unique_ptr<FlipState>& fs : flipstates)
-- 
cgit v1.2.3