diff options
| author | Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> | 2025-09-13 18:23:09 +0300 |
|---|---|---|
| committer | Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> | 2025-12-18 12:23:57 +0200 |
| commit | 0271a62e676d50940ec5f86d94cf66629894c25f (patch) | |
| tree | 6cafec033afba5469dbfacc1dd3e4c621bcdd0cc /utils/kmstest.cpp | |
| parent | bb4d48fbf9d0ad6be570d9c9b052f835f3a8b0d5 (diff) | |
fix: Replace C-style casts with C++ casts
This commit addresses cppcheck warnings about C-style casts (cstyleCast)
by replacing them with appropriate C++ casts. C-style casts are considered
dangerous because they can perform unsafe conversions without compile-time
type checking, while C++ casts are more explicit and type-safe.
Changes made:
- static_cast for safe type conversions (e.g., void* to struct*)
- reinterpret_cast for pointer type conversions (e.g., uint8_t* to char*)
- Combined static_cast and reinterpret_cast for integer-to-pointer conversions
Fixed files:
- kmscube/cube-gles2.cpp: GLvoid* casts for OpenGL vertex attribute pointers
- kmscube/cube-wl.cpp: Wayland interface pointer casts
- kmscube/cube-x11.cpp: X11 window handle conversion
- utils/fbtest.cpp: mmap return value cast
- utils/kmstest.cpp: Framebuffer pointer arithmetic
- utils/kmsview.cpp: Framebuffer memory mapping cast
Diffstat (limited to 'utils/kmstest.cpp')
| -rw-r--r-- | utils/kmstest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/utils/kmstest.cpp b/utils/kmstest.cpp index 8340fa7..c6efb45 100644 --- a/utils/kmstest.cpp +++ b/utils/kmstest.cpp @@ -748,7 +748,7 @@ static string fb_crc(IFramebuffer* fb) for (unsigned y = 0; y < fb->height(); ++y) { for (unsigned x = 0; x < fb->width(); ++x) { - uint32_t* p32 = (uint32_t*)(p + fb->stride(0) * y + x * 4); + uint32_t* p32 = reinterpret_cast<uint32_t*>(p + fb->stride(0) * y + x * 4); RGB rgb(*p32); r = crc16(r, rgb.r); |
