diff options
| author | Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> | 2025-09-13 18:23:09 +0300 |
|---|---|---|
| committer | Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> | 2025-12-18 12:23:57 +0200 |
| commit | 0271a62e676d50940ec5f86d94cf66629894c25f (patch) | |
| tree | 6cafec033afba5469dbfacc1dd3e4c621bcdd0cc /utils/fbtest.cpp | |
| parent | bb4d48fbf9d0ad6be570d9c9b052f835f3a8b0d5 (diff) | |
fix: Replace C-style casts with C++ casts
This commit addresses cppcheck warnings about C-style casts (cstyleCast)
by replacing them with appropriate C++ casts. C-style casts are considered
dangerous because they can perform unsafe conversions without compile-time
type checking, while C++ casts are more explicit and type-safe.
Changes made:
- static_cast for safe type conversions (e.g., void* to struct*)
- reinterpret_cast for pointer type conversions (e.g., uint8_t* to char*)
- Combined static_cast and reinterpret_cast for integer-to-pointer conversions
Fixed files:
- kmscube/cube-gles2.cpp: GLvoid* casts for OpenGL vertex attribute pointers
- kmscube/cube-wl.cpp: Wayland interface pointer casts
- kmscube/cube-x11.cpp: X11 window handle conversion
- utils/fbtest.cpp: mmap return value cast
- utils/kmstest.cpp: Framebuffer pointer arithmetic
- utils/kmsview.cpp: Framebuffer memory mapping cast
Diffstat (limited to 'utils/fbtest.cpp')
| -rw-r--r-- | utils/fbtest.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/utils/fbtest.cpp b/utils/fbtest.cpp index 913d773..4992895 100644 --- a/utils/fbtest.cpp +++ b/utils/fbtest.cpp @@ -33,10 +33,10 @@ int main(int argc, char** argv) r = ioctl(fd, FBIOGET_FSCREENINFO, &fix); FAIL_IF(r, "FBIOGET_FSCREENINFO failed"); - uint8_t* ptr = (uint8_t*)mmap(NULL, + uint8_t* ptr = static_cast<uint8_t*>(mmap(NULL, var.yres_virtual * fix.line_length, PROT_WRITE | PROT_READ, - MAP_SHARED, fd, 0); + MAP_SHARED, fd, 0)); FAIL_IF(ptr == MAP_FAILED, "mmap failed"); |
